Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR] Add select operation #796

Merged
merged 1 commit into from
Aug 21, 2024
Merged

[CIR] Add select operation #796

merged 1 commit into from
Aug 21, 2024

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Aug 18, 2024

This PR adds a new cir.select operation. This operation won't be generated directly by CIRGen but it is useful during further CIR to CIR transformations.

This PR addresses #785 .

@Lancern Lancern marked this pull request as ready for review August 18, 2024 11:07
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nit/simplification

clang/lib/CIR/Dialect/IR/CIRDialect.cpp Outdated Show resolved Hide resolved
This patch adds a new `cir.select` operation. This operation won't be generated
directly by CIRGen but it is useful during further CIR to CIR transformations.

This patch addresses llvm#785 .
@Lancern
Copy link
Member Author

Lancern commented Aug 21, 2024

Rebased onto the latest main.

@bcardosolopes bcardosolopes merged commit f0a7791 into llvm:main Aug 21, 2024
6 checks passed
@Lancern Lancern deleted the select-op branch August 27, 2024 14:12
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
This PR adds a new `cir.select` operation. This operation won't be
generated directly by CIRGen but it is useful during further CIR to CIR
transformations.

This PR addresses llvm#785 .
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This PR adds a new `cir.select` operation. This operation won't be
generated directly by CIRGen but it is useful during further CIR to CIR
transformations.

This PR addresses llvm#785 .
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This PR adds a new `cir.select` operation. This operation won't be
generated directly by CIRGen but it is useful during further CIR to CIR
transformations.

This PR addresses llvm#785 .
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
This PR adds a new `cir.select` operation. This operation won't be
generated directly by CIRGen but it is useful during further CIR to CIR
transformations.

This PR addresses llvm#785 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants