[CIR] Add Case Op Kind Range #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenpen
commented
Jun 2, 2024
wenpen
force-pushed
the
smart_switch_case_range
branch
from
03c3c37
to
5684911
Compare
bcardosolopes
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
LGTM! Thanks for improving this, one minor comment inline and I'll merge this.
FWIW, some cool small optimizations ideas to work in future PRs:
- Recognize ranges that all fallthrough to the same block and transform it to just one range (e.g. the testcase in
sw1). - Recognize
anyofs in which elements are monotonic and convert those to a range.
One way to implement this is to add a SwitchOp::fold method, and add SwitchOp to the list of patterns in MergeCleanups.cpp.
|
Comments added, thanks for pointing out the future works! |
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
Make lowering result of case range smart. Resolve llvm#632
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
Make lowering result of case range smart. Resolve llvm#632
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
Make lowering result of case range smart. Resolve llvm#632
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
Make lowering result of case range smart. Resolve llvm#632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make lowering result of case range smart.
Resolve #632