[CIR][Lowering] Add MLIR lowering support for CIR shift operations #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancern
suggested changes
May 27, 2024
Comment on lines
340
to
341
| else | ||
| return rewriter.create<mlir::arith::BitcastOp>(loc, dstTy, src); |
There was a problem hiding this comment.
No tests cover this branch. Consider adding a test for it.
Besides, CIR currently does not generate MLIR integer types with signedness semantics. Thus the bitcast here should be unnecessary. But this involves modifying existing code so it's OK if you don't address this in this PR.
There was a problem hiding this comment.
You are right, I have added test coverage for the last branch
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
…lvm#630) This pr adds cir.shift lowering to MLIR passes and test files.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…lvm#630) This pr adds cir.shift lowering to MLIR passes and test files.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…lvm#630) This pr adds cir.shift lowering to MLIR passes and test files.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…lvm#630) This pr adds cir.shift lowering to MLIR passes and test files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds cir.shift lowering to MLIR passes and test files.