[CIR][CIRGen] Handle __extension__ keyword #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The repro-case Compilation of this test fails with |
|
✅ With the latest revision this PR passed the C/C code formatter. |
YazZz1k
force-pushed
the
cpp-127
branch
2 times, most recently
from
5bbc8ec
to
c6e4682
Compare
Lancern
reviewed
Jan 26, 2024
| mlir::Value VisitUnaryExtension(const UnaryOperator *E) { | ||
| llvm_unreachable("NYI"); | ||
| TestAndClearIgnoreResultAssign(); |
There was a problem hiding this comment.
This diverges from the original clang CodeGen. Could you add some explanation regarding this change?
There was a problem hiding this comment.
I can't), because it is my mistake. I fixed this
lanza
force-pushed
the
main
branch
2 times, most recently
from
4e069c6
to
79d4dc7
Compare
|
@lanza just rebased and this has the side effect of breaking GH PR workflow, making it impossible to review, apologies. Please rebase! |
bcardosolopes
requested changes
Jan 31, 2024
| int foo(void) { return __extension__ 0b101010; } | ||
|
|
||
| //CHECK: cir.func @foo() -> !s32i extra( {inline = #cir.inline<no>, optnone = #cir.optnone} ) { | ||
| //CHECK-NEXT: %0 = cir.alloca !s32i, cir.ptr <!s32i>, ["__retval"] {alignment = 4 : i64} |
There was a problem hiding this comment.
Minor nitpicks here:
- The file name is misspelled, should be
gnu-extension. - Use FileCheck regexes for MLIR values, for example:
%[[addr:.*]] = cir.alloca !s32i, cir.ptr <!s32i>,
%[[const:.*]] = cir.const(#cir.int<42> : !s32i) : !s32i
cir.store %[[const]], %[[addr]] : !s32i, cir.ptr <!s32i>
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
Support \_\_extension\_\_ keyword in CIRGen
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
Support \_\_extension\_\_ keyword in CIRGen
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Support \_\_extension\_\_ keyword in CIRGen
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Support \_\_extension\_\_ keyword in CIRGen
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
Support \_\_extension\_\_ keyword in CIRGen
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Support \_\_extension\_\_ keyword in CIRGen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support __extension__ keyword in CIRGen