Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depth: 0, add depth: false #326

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Fix depth: 0, add depth: false #326

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift click to select a range
a30e4b1
[Tests] add tests for `depth=0` and `depth=false` behavior, both curr…
idler8 Aug 8, 2019
649f05f
[New] add `depth=false` to preserve the original key; [Fix] `depth=0`…
ljharb Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Tests] add tests for depth=0 and depth=false behavior, both curr… 
…ent and intuitive/intended
  • Loading branch information
@idler8 @ljharb
idler8 authored and ljharb committed Aug 8, 2019
commit a30e4b1cdf8f77bf4f84b5f8c6ee4bbde9d95792
24 changes: 24 additions & 0 deletions test/parse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 52,30 @@ test('parse()', function (t) {
st.end();
});

t.test('current behavior with depth = 0', function (st) {
st.deepEqual(qs.parse('a[0]=b&a[1]=c', { depth: 0 }), { a: { '[0]': 'b', '[1]': 'c' } });
st.deepEqual(qs.parse('a[0][0]=b&a[0][1]=c&a[1]=d&e=2', { depth: 0 }), { a: { '[0][0]': 'b', '[0][1]': 'c', '[1]': 'd' }, e: '2' });
st.end();
});

t.test('uses original key when depth = 0', { skip: true, todo: true }, function (st) {
st.deepEqual(qs.parse('a[0]=b&a[1]=c', { depth: 0 }), { 'a[0]': 'b', 'a[1]': 'c' });
st.deepEqual(qs.parse('a[0][0]=b&a[0][1]=c&a[1]=d&e=2', { depth: 0 }), { 'a[0][0]': 'b', 'a[0][1]': 'c', 'a[1]': 'd', e: '2' });
st.end();
});
Copy link
Contributor Author

@idler8 idler8 Aug 9, 2019 •
edited by ljharb
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充了上面的测试
我觉得这是一个新规则

edit (ljharb): translation added

Added the above test
I think this is a new rule.


t.test('current behavior with depth = false', function (st) {
st.deepEqual(qs.parse('a[0]=b&a[1]=c', { depth: false }), { a: ['b', 'c'] });
st.deepEqual(qs.parse('a[0][0]=b&a[0][1]=c&a[1]=d&e=2', { depth: false }), { a: [['b', 'c'], 'd'], e: '2' });
st.end();
});

t.test('uses original key when depth = false', { skip: true, todo: true }, function (st) {
st.deepEqual(qs.parse('a[0]=b&a[1]=c', { depth: false }), { 'a[0]': 'b', 'a[1]': 'c' });
st.deepEqual(qs.parse('a[0][0]=b&a[0][1]=c&a[1]=d&e=2', { depth: false }), { 'a[0][0]': 'b', 'a[0][1]': 'c', 'a[1]': 'd', e: '2' });
st.end();
});

t.deepEqual(qs.parse('a=b&a=c'), { a: ['b', 'c'] }, 'parses a simple array');

t.test('parses an explicit array', function (st) {
Expand Down