chore: update to http 1.x crates #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
flokli
force-pushed
the
bigtable-http-1
branch
from
44b8938
to
de2a37d
Compare
|
@cbrewster helped me out on finishing this :-) hyper doesn't use tokio types anymore, so an adapter from hyper_utils has to be used: https://github.com/hyperium/hyper/blob/master/CHANGELOG.md#breaking-changes-3 / hyperium/hyper@f9f65b7 |
This requires updating prost crates to 0.13.x, tonic to 0.12.x and prost-wkt-* to 0.6.*. Only the examples still pull in http 0.x, due to seanmonstar/warp#1090, but that shouldn't affect consumers of bigtable_rs. Co-Authored-By: Connor Brewster <[email protected]>
flokli
force-pushed
the
bigtable-http-1
branch
from
de2a37d
to
1818355
Compare
This was referenced Aug 27, 2024
|
This now also includes the |
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Aug 28, 2024
This bumps bigtable_rs to liufuyang/bigtable_rs#86, allowing us to drop our second set of prost/tonic/http/axum crates. Change-Id: I70f9150289c3e8611ebe8a7d99490e3dfd085a6e Reviewed-on: https://cl.tvl.fyi/c/depot/ /12384 Tested-by: BuildkiteCI Reviewed-by: Connor Brewster <[email protected]> Autosubmit: flokli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires updating prost crates to 0.13.x, tonic to 0.12.x and prost-wkt-* to 0.6.*.
Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect consumers of bigtable_rs.
Closes #70
Closes #77
Closes #78
Closes #79
Closes #80
Closes #81
Closes #82
Closes #84
Closes #85
Closes #87
Closes #88