fix(#3554): correct module_to_os_path to return directory paths
#3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: small
pr/external
Triage Required 🏥
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3565 /- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 329 329
Lines 14965 14965
Branches 2382 2382
=======================================
Hits 14708 14708
Misses 116 116
Partials 141 141 ☔ View full report in Codecov by Sentry. |
JacobCoffee
changed the title
JacobCoffee
changed the title
module_to_os_path to return directory paths
JacobCoffee
changed the title
module_to_os_path to return directory pathsmodule_to_os_path to return directory paths
cofin
approved these changes
Aug 25, 2024
|
@all-contributors, add @supercoder-dev for bugs, code |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3565 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the issue, we need to update the
module_to_os_pathfunction to check if the found path is a file. If it is, we should return the parent directory instead. This can be done by usingPath(src.origin).parentifsrc.originis a file.