-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guldoman's Pocket Design #1764
Draft
adamharrison
wants to merge
19
commits into
lite-xl:master
Choose a base branch
from
adamharrison:PR/pockets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Guldoman's Pocket Design #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit of Guldoman's pocket design, to replace locked views.
The problem as it stands is that to add views, plugins need to basically split off their own nodes. This isn't sustainable, because if you have a ton of plugins they're going to start stepping on each other, and unless they're specifically coded around each other, it devolves into chaos.
Enter, the pocket system. Where you can simply tell RootView to add your view to a specific pocket, and have the central system worry about exactly how to lay it out, and where. It's configurable by the user in
config
, and in theory should allow many plugins to play nicely with each other.The PR currently works for all the defaults (and saves us some SLOC); but I'm going to be testing this going forward on my IDE plugins, to see how easy it is to get them to all play nice. Will report back on this.