Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test case for "Context consumers re-render after being disconnected by parent" #4699

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Failing test case for "Context consumers re-render after being disconnected by parent" #4699

wants to merge 1 commit into from

Conversation

joliss
Copy link

@joliss joliss commented Jul 11, 2024 •
edited
Loading

This is a failing test case to reproduce the issue #4700.

Output:

~/src/lit/packages/context $ npm run test:dev

> @lit/[email protected] test:dev
> wireit

...

development/test/disconnected_test.js:

 🚧 Browser logs:
      Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.
      parent 0
      parent 1
      child 1 connected = true
      parent 2
      child 2 connected = false      <----------- this should not be happening
      parent 3

 ❌ disconnected > does not render after it is disconnected by parent component
      AssertionError: expected 2 to equal 1
        expected - actual

      -2
       1

      at o.<anonymous> (src/test/disconnected_test.ts:65:11)

...

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d09a62f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla Google CLA
Copy link

google-cla bot commented Jul 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@joliss joliss mentioned this pull request Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf will be requested when the pull request is marked ready for review kevinpschaaf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joliss