Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[labs/router] Extend lit-router to support hash-based routing #4685

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[labs/router] Extend lit-router to support hash-based routing #4685

wants to merge 2 commits into from

Conversation

maischus
Copy link

lit-router currently only uses the pathname to perform the routing. This change extends the routing to search and hash part of an URL.

This should fix #3517 and allow urlpattern-polyfill to work correctly (kenchris/urlpattern-polyfill#129) for hash-based routing.

@justinfagnani What are your thoughts on this approach? tailGroup has not been adapted yet. I would like to wait for your thoughts before continuing.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: 4cb67c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla Google CLA
Copy link

google-cla bot commented Jun 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[labs/router] Hash routing doesn't work
1 participant
@maischus