Add GroupieAdapter to use GroupieViewHolder by default #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You know, the idea is sound, in this case GrouoieViewHolder is no longer just a typealias. I'm sure we need to add some docs on GroupieAdapter, but this kinda begs the question why we had a generic parameter in the first place (as a user had to extend from I'll try to check through if this has any implications, the idea is sound. Thanks for the PR. |
|
@Zhuinden totally agree with you, I mean my first try was just removing the generic parameter but then I thought wouldn't be cool to break library users code. If you have a better idea in mind please LMK :) |
|
I think I should have merged this right there and then. Nonetheless, thanks! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the following ToDo:
GroupAdapter<GroupieViewHolder>() //TODO get rid of this parameterBasically
GroupieAdapterextends fromGroupAdapterusingGroupieViewHolder. This way it's backward compatible and allow us to get rid of the generic parameter in kotlin. @lisawray what do you think?