Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base ExpandableGroup on Section #362

Merged

Conversation

MrLogic85
Copy link

This will allow users to use the update method and footers, and remove duplicate code.

@Zhuinden
Copy link
Collaborator

This looks correct.

Thanks!

@Zhuinden Zhuinden merged commit a4f104e into lisawray:master Jan 13, 2021
@Zhuinden
Copy link
Collaborator

Actually, this makes 3 tests in ExpandableGroupTest fail. Next time I'll be a bit more vigilant. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants