Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cinnamon-settings and adwaita.xml failed #5586

Closed
cronolio opened this issue Aug 21, 2016 · 13 comments · Fixed by #8996
Closed

cinnamon-settings and adwaita.xml failed #5586

cronolio opened this issue Aug 21, 2016 · 13 comments · Fixed by #8996
Labels

Comments

@cronolio
Copy link

cronolio commented Aug 21, 2016

os: gentoo
cinnamon 3.0.7
gentoo use patch

when i run cinnamon-settings
Loading Backgrounds module
Failed to read filename from /usr/share/backgrounds/gnome/adwaita-timed.xml: list index out of range
Failed to detect mimetype for None: execv() arg 2 must contain only strings

yes. i'm was reproduce it on cinnamon distro: install gnome-backgrounds and drop adwaita.xml into /usr/share/cinnamon-background-properties. looks like cs_backgrounds.py was trying work with xml as with regular image file

@JosephMcc JosephMcc added the BUG label Aug 24, 2016
@werfu
Copy link

werfu commented Aug 31, 2016

Cinnamon 3.0.7 here on Arch though, same issue happening. My desktop background is also corrupted but the selected wallpaper do get displayed correctly on the lock screen though.

@ranolfi
Copy link

ranolfi commented Jun 6, 2017

Same issue here with Cinnamon 3.2.4, 3.4.1 and bleeding-edge git version as well. Currently working with Nemo 3.4.2 on Arch Linux 64 bits.

@ellishg
Copy link
Contributor

ellishg commented Jul 8, 2019

My fix was to change cs_backgrounds.py line 773 to

if len(staticNode) > 0 and staticNode[-1].tag == "size":

Before the change, there were no Adwaita backgrounds at all within cinnamon-settings/backgrounds. Now the background shows up and works as expected.

@mammo0
Copy link

mammo0 commented Nov 7, 2019

@sparkasaurusRex thanks for this fix!

@ranolfi
Copy link

ranolfi commented Dec 4, 2019

@icarter09, will this fix be implemented in the source code?

@icarter09
Copy link
Member

icarter09 commented Dec 4, 2019

@ranolfi thanks for the update because I thought it was already implemented. I take it you are still having this issue?

@sparkasaurusRex did you put up a PR with your fix?

@ranolfi
Copy link

ranolfi commented Dec 4, 2019

I am indeed, @icarter09. This has not been pulled into the main repo.

@icarter09
Copy link
Member

icarter09 commented Dec 4, 2019

@ranolfi feel free to put a PR together containing this fix. If you aren't able to, let me know.

@ranolfi
Copy link

ranolfi commented Dec 4, 2019

Will do - unless of course @sparkasaurusRex wants to do the honors! :)

@icarter09
Copy link
Member

No worries. I'm a fan of whatever it takes to make Mint and Cinnamon better. :)

@ranolfi if you do happen to do it, make sure to tag this issue in the PR.

@icarter09 icarter09 reopened this Dec 4, 2019
@ellishg
Copy link
Contributor

ellishg commented Dec 4, 2019

Thanks @ranolfi I can make a PR. Not sure why I didn't do that when I found the fix.

@icarter09
Copy link
Member

@sparkasaurusRex no worries and thanks for doing that.

ellishg added a commit to ellishg/cinnamon that referenced this issue Dec 4, 2019
The python script `cs_backgrounds.py` was failing because an array was
not checked to be empty before being indexed.

Fixes linuxmint#5586
clefebvre pushed a commit that referenced this issue Dec 4, 2019
The python script `cs_backgrounds.py` was failing because an array was
not checked to be empty before being indexed.

Fixes #5586
@eli-schwartz
Copy link
Contributor

Cool, thanks for submitting a PR. ;)

I just uploaded the fixed package to archlinux's community repository, so within the next couple of hours (depending on when your current mirror syncs) you can get the fix by running:

pacman -Syu 'cinnamon>=4.4.3-1'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants