-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepin-desktop-schemas: non-deterministic overrides #5117
deepin-desktop-schemas: non-deterministic overrides #5117
Comments
Thanks for bug report, Now the key is sorted first, can you try this pr? if it works, I think we can merge it |
if there is still problems, please open it |
I applied 98.patch on 5.10.11 but still get various diffs in .override files: [com.deepin.wrap.pantheon.desktop.gala.animations]
+enable-animations=true
+open-duration=350
snap-duration=250
close-duration=300
menu-duration=150
minimize-duration=200
workspace-switch-duration=300
-enable-animations=true
-open-duration=350
[com.deepin.dde.power]
-line-power-sleep-delay=0
-battery-sleep-delay=0
ambient-light-adjust-brightness=false
screen-black-lock=false
+line-power-sleep-delay=0
+battery-sleep-delay=0 |
which file are you looking into? you should try the lastest tag, and look into result folder. the keys should have been sorted
|
The first diff is from /usr/share/glib-2.0/schemas/90_deepin_base.gschema.override Is there another patch that I would need to pick? |
I don"t know what happened, can you try clone the repo , and run make , to see the the target under result folders? the keys are sorted by string, the shouldn"t be random |
Ah, I just remembered that we build the |
So when testing correctly, it is indeed fixed with the 98.patch. 👍 |
SUMMARY | 问题概要
While working on reproducible builds for openSUSE, I found that
building our
deepin-desktop-schemas
twice produced diffs in 4 override filesSOFTWARE/OS VERSIONS | 软件/系统版本信息
PRE-REQUIREMENT | 预置条件
No response
STEPS TO REPRODUCE | 复现步骤
build it twice
OBSERVED RESULT | 观察到的结果
4 files differed:
EXPECTED RESULT | 期望的结果
It should be possible to get bit-identical outputs in two builds.
Please sort entries during processing.
ADDITIONAL INFORMATION | 额外补充
My guess is that keyfile dictionaries don"t have deterministic ordering in output at
https://github.com/linuxdeepin/deepin-desktop-schemas/blob/master/tools/override/main.go#L156
The text was updated successfully, but these errors were encountered: