Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve original value of animation settings after teardown #25

Closed
bootstraponline opened this issue Sep 27, 2016 · 4 comments
Closed
Assignees
Labels

Comments

@bootstraponline
Copy link
Contributor

Animations are unconditionally enabled on TestButler.teardown. It'd be nice to pass some options to teardown to either keep animations disabled or at least preserve their original value.

@bootstraponline bootstraponline changed the title Stop enabling animations onDestoy. Stop enabling animations on teardown. Sep 27, 2016
@drewhannay
Copy link
Contributor

Preserving the original value makes sense...I think I had noticed that before and forgot to make an issue. I'll edit the issue title.

@drewhannay drewhannay changed the title Stop enabling animations on teardown. Preserve original value of animation settings after teardown Sep 27, 2016
@Kisty
Copy link
Contributor

Kisty commented Oct 6, 2016

Not sure if this should be its own issue but does the disabling animations take care of the Window, Transition and Animator scales altogether?

@drewhannay
Copy link
Contributor

Yes, it changes all three settings. Are you wanting to change individual settings? I think that would probably be out of scope for Test Butler, since Test Butler is really just for automated tests, not necessarily a utility for general development.

@Kisty
Copy link
Contributor

Kisty commented Oct 6, 2016

Ah great. That's all I needed to know. No, I don't want to be able to control them individually but I find working with the emulator with no animations makes it quicker to develop with.

@drewhannay drewhannay self-assigned this Nov 4, 2016
drewhannay pushed a commit to drewhannay/test-butler that referenced this issue Nov 4, 2016
Fixes linkedin#25
Also added a test that animations are disabled while ButlerService is running
drewhannay pushed a commit to drewhannay/test-butler that referenced this issue Nov 4, 2016
Fixes linkedin#25
Also added a test that animations are disabled while ButlerService is running
@drewhannay drewhannay added the bug label Nov 4, 2016
drewhannay pushed a commit that referenced this issue Nov 4, 2016
Fixes #25
Also added a test that animations are disabled while ButlerService is running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants