Incorporate remaining stroke rework and MSAA changes into the encoding and shaders crates #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing fields and remove stale ones following stroke rework.
The `fine` stage is now bundled as 3 different instances: fine_area, fine_msaa8, and fine_msaa16.
The force_rw_storage feature is a hack that enables a renderer to bind suballocations from the same buffer object to both readonly and read-write bindings inside a pipeline layout. The AA variants of the fine stage don't compile with this feature enabled, since the read-write PTCL buffer results in a uniformity analysis failure. Address this by excluding the `fine` stage from the force_rw_storage feature to preserve the shader's correctness. Since all storage bindings in `fine` are readonly, there is no restriction against binding suballocations to any of the fine pipeline variants in the first place.
raphlinus
approved these changes
Jan 16, 2024
raphlinus
added a commit
that referenced
this pull request
Feb 12, 2024
This cleans up a loose end in #421, which renumbered the resources in the path_count GPU shader but not the CPU shader. It fixes an immediate panic when running with --use-cpu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of changes to make the stroke rework and MSAA pipeline features available via the
vello_encodingandvello_shaderscrates:WorkgroupSizesandBufferSizesstructures.vello_encoding.fine_area,fine_msaa8, andfine_msaa16instances.