Make fine.wgsl integer literals explicitly signed #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
I'm not going to merge, as I haven't run this change.
But if someone else can confirm this still executes as expected, that would be helpful.
Is there a corresponding Naga issue? i.e. tracking that the abstractint doesn't get maintained through unary minus (?)
| @@ -311,7 311,7 @@ fn fill_path_ms(fill: CmdFill, local_id: vec2<u32>, result: ptr<function, array< | |||
| let mask1_exp = (mask_b >> 4u) & 0x1010101u; | |||
| var mask1_signed = select(mask1_exp, u32(-i32(mask1_exp)), is_down); | |||
| if is_bump { | |||
| let bump_delta = select(u32(-0x1010101), 0x1010101u, is_down); | |||
| let bump_delta = select(u32(-0x1010101i), 0x1010101u, is_down); | |||
| @@ -400,7 400,7 @@ fn fill_path_ms(fill: CmdFill, local_id: vec2<u32>, result: ptr<function, array< | |||
| } | |||
| // packed_w now contains the winding numbers for a slice of 4 pixels, | |||
| // each relative to the top left of the row. | |||
| for (var i = 0u; i < local_id.y >> 2u; i ) { | |||
| for (var i = 0u; i < (local_id.y >> 2u); i ) { | |||
There was a problem hiding this comment.
Is this consistent with elsewhere in our source?
I think the relational expression binds more tightly than the shift operation
simbleau
approved these changes
Dec 20, 2023
|
Related: linebender/bevy_vello#17 |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous literals were being interpreted as an AbstractInt, which according to the u32 constructor:
I made the literals explicit signed integers so the correct constructor overload is used.