Remove an invalid content-length in a gRPC streaming response.
#4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If a wrong content-length is set, the request/stream is reset by the Netty HTTP/2 codec. Most gRPC server call implmentations do not set a `content-length` to response headers. But some gRPC implementations such as Monix-gRPC send a `content-length` which was the content-length of the request. I guess the runtime just uses the incoming `Metadata` as the response `Metadata` without creating a new one. Related: monix/monix-grpc#43 Modifications: - Remove the `content-length` in headers of the gRPC streaming response if set Result: - A custom content-length is automatically stripped when response streaming is used in `GrpcService`.
minwoox
approved these changes
Oct 4, 2022
ikhoon
force-pushed
the
remove-invalid-content-length
branch
from
414d466
to
f77a8fd
Compare
Codecov ReportBase: 74.10% // Head: 74.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4460 /- ##
============================================
Coverage 74.10% 74.13% 0.03%
- Complexity 18131 18155 24
============================================
Files 1529 1530 1
Lines 67229 67254 25
Branches 8494 8496 2
============================================
Hits 49820 49860 40
Misses 13350 13336 -14
Partials 4059 4058 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jrhee17
approved these changes
Oct 5, 2022
| // implemented stubs such as Monix-gRPC. https://github.com/monix/monix-grpc/issues/43 | ||
| // If a wrong content-length is set, an RST_STREAM error occurs at the Netty level. | ||
| // We don't need to care about the content-length of a unary call because it is eventually | ||
| // adjusted when the response is aggregated. |
There was a problem hiding this comment.
Verified chunked encoding is used for http1 as well, so sgtm 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If a wrong content-length is set, the request/stream is reset by the Netty HTTP/2 codec. Most gRPC server call implmentations do not set a
content-lengthto response headers. But some gRPC implementations such as Monix-gRPC send acontent-lengthwhich was in the request content-length. I guess the runtime uses the incomingMetadataas the responseMetadataitself.Related: monix/monix-grpc#43
Modifications:
content-lengthin headers of the gRPC streaming response if setResult:
GrpcService.