Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed dropdown position to top #11520

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

sanjay-sol
Copy link
Contributor

Closes: #11495

Description:

This pull request addresses an issue where the MultiSelect dropdown for Group Members would cover the save button, leading to a poor user experience. Users were often confused and accidentally clicked the 'X' button instead of saving their changes.

Before Changes:

Screenshot 2024-09-11 at 4 27 59 AM

After Changes:

Screenshot 2024-09-11 at 4 29 02 AM

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

Copy link

netlify bot commented Sep 10, 2024

👷 Deploy request for peaceful-bassi-cbf284 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6745ab0

@ZeRego ZeRego self-assigned this Sep 16, 2024
@ZeRego ZeRego changed the title feat: changed dropdown position to top fix: changed dropdown position to top Sep 16, 2024
@ZeRego ZeRego merged commit 888bb7a into lightdash:main Sep 16, 2024
7 checks passed
lightdash-bot pushed a commit that referenced this pull request Sep 16, 2024
## [0.1255.3](0.1255.2...0.1255.3) (2024-09-16)

### Bug Fixes

* changed dropdown position to top ([#11520](#11520)) ([888bb7a](888bb7a))
* show minimal table cell context menu ([#11466](#11466)) ([3e871da](3e871da))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1255.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The user drop-down blocks the save button in user groups
3 participants