chore: dont update filters until apply on semantic viewer #11514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlas
requested a deployment
to
update-filter-on-apply - jaffle_db_pg_13 PR #11514
Render
Abandoned
owlas
deployed
to
update-filter-on-apply - headless-browser PR #11514
Render
Active
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
owlas
temporarily deployed
to
update-filter-on-apply - lightdash PR #11514
Render
Destroyed
magnew
changed the title
almeidabbm
reviewed
Sep 10, 2024
| values: [], | ||
| }), | ||
| ); | ||
| setDraftFilters((prev) => [...prev, newFilter]); | ||
| }} | ||
| onCancel={ | ||
| filters.length > 0 |
There was a problem hiding this comment.
I believe this should also be draftFilters
owlas
temporarily deployed
to
update-filter-on-apply - lightdash PR #11514
Render
Destroyed
owlas
temporarily deployed
to
update-filter-on-apply - headless-browser PR #11514
Render
Destroyed
almeidabbm
approved these changes
Sep 12, 2024
|
🎉 This PR is included in version 0.1255.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11490
Description:
In the semantic layer, don't apply filters until the Apply button is clicked
Reviewer actions