Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show pivoted results for non-table sql chart view #11511

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

joaoviana
Copy link
Contributor

Closes: #11210

Description:

Display pivoted table for non-table sql charts in view mode

Screenshot 2024-09-10 at 16 25 37 Screenshot 2024-09-10 at 16 25 43

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@joaoviana joaoviana self-assigned this Sep 10, 2024
@owlas owlas requested a deployment to feat/show-pivoted-results - jaffle_db_pg_13 PR #11511 September 10, 2024 15:27 — with Render Abandoned
@owlas owlas temporarily deployed to feat/show-pivoted-results - headless-browser PR #11511 September 10, 2024 15:27 — with Render Destroyed
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit 743d2bd
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/66e0655bfc9c6e0008699ec7

@owlas owlas temporarily deployed to feat/show-pivoted-results - lightdash PR #11511 September 10, 2024 15:28 — with Render Destroyed
Copy link
Collaborator

@rephus rephus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great !

@joaoviana joaoviana merged commit a8f68e1 into main Sep 10, 2024
48 of 52 checks passed
@joaoviana joaoviana deleted the feat/show-pivoted-results branch September 10, 2024 16:07
lightdash-bot pushed a commit that referenced this pull request Sep 10, 2024
# [0.1254.0](0.1253.0...0.1254.0) (2024-09-10)

### Features

* show pivoted results for non-table sql chart view ([#11511](#11511)) ([a8f68e1](a8f68e1))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1254.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sql Runner charts should show pivoted results below
4 participants