feat: Add AWS SES support to email client #11467
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for peaceful-bassi-cbf284 pending review.Visit the deploys page to approve it
|
|
Hey @gpdenny thanks for this PR, at a quick glance it looks excellent. I'm going to chat with the team about whether we want to maintain this. We intentionally chose to use SMTP credentials for the broadest compatibility. However I see the benefits of eliminating long lived SMTP credentials. Let me get back to you next week! |
|
Hi @owlas just following up on this one 🙏 Any thoughts on maintaining? |
|
Hi @gpdenny this looks like a good PR! The team is a bit slammed at the moment so we haven't got bandwidth to review it but we will get to it 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11463
Description:
Add support for AWS SES transport in email client.
Followed the same configuration / client convention as with S3.
(If there are further integrations with AWS I think it would be more appropriate to create a global configuration for AWS, instead repeating per service, as this is more likely to match how people write policies. Didn't want to potentially make breaking changes here to do that.)
Tested locally with Localstack and in a sandbox environment in AWS.
Also tested SMTP locally to ensure no regressions.
Reviewer actions