Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle setX/YAxisReference defaults in slice #11004

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

joaoviana
Copy link
Contributor

Closes: #10984

Description:

I believe this are the touch points
Ensures we set defaults on the slice

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@joaoviana joaoviana requested review from magnew and ZeRego August 2, 2024 16:56
@joaoviana joaoviana self-assigned this Aug 2, 2024
@owlas owlas requested a deployment to refactor/handle-defaults-in-actions - jaffle_db_pg_13 PR #11004 August 2, 2024 16:57 — with Render Abandoned
@owlas owlas temporarily deployed to refactor/handle-defaults-in-actions - headless-browser PR #11004 August 2, 2024 16:57 — with Render Destroyed
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit 7efbce6
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/66ad0fdb2ebedb00083649b0

@owlas owlas temporarily deployed to refactor/handle-defaults-in-actions - lightdash PR #11004 August 2, 2024 16:58 — with Render Destroyed
Copy link
Contributor

@magnew magnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

@joaoviana joaoviana merged commit fd6948a into main Aug 5, 2024
44 of 52 checks passed
@joaoviana joaoviana deleted the refactor/handle-defaults-in-actions branch August 5, 2024 08:53
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1202.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure actions handle chart defaults
4 participants