Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace useDebouncedValue with useDeferredValue #11003

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

joaoviana
Copy link
Contributor

@joaoviana joaoviana commented Aug 2, 2024

Closes: N/A

Description:

Use useDeferredValue to deal with this exact issue: when the user scrolls up and down the results panel it should affect the bar chart's height, but it shouldn't block the UI thread

demo:

deffered-valued.mov

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@owlas owlas requested a deployment to chore/use-deferred-value-for-bar-chart-size - jaffle_db_pg_13 PR #11003 August 2, 2024 16:16 — with Render Abandoned
@owlas owlas temporarily deployed to chore/use-deferred-value-for-bar-chart-size - headless-browser PR #11003 August 2, 2024 16:16 — with Render Destroyed
@joaoviana joaoviana requested a review from magnew August 2, 2024 16:16
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit d9fbf19
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/66ad066068ae1400085cb918

@joaoviana joaoviana requested a review from ZeRego August 2, 2024 16:16
@joaoviana joaoviana self-assigned this Aug 2, 2024
@joaoviana joaoviana added the 🖥 frontend This issue requires changes to the frontend label Aug 2, 2024
@owlas owlas temporarily deployed to chore/use-deferred-value-for-bar-chart-size - lightdash PR #11003 August 2, 2024 16:17 — with Render Destroyed
Copy link
Contributor

@magnew magnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well

@joaoviana joaoviana merged commit a119251 into main Aug 5, 2024
46 of 53 checks passed
@joaoviana joaoviana deleted the chore/use-deferred-value-for-bar-chart-size branch August 5, 2024 09:08
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1202.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 frontend This issue requires changes to the frontend released
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants