Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Correct operation IDs in controllers #10993

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Correct operation IDs in controllers #10993

wants to merge 2 commits into from

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Aug 2, 2024

Closes: xxx

I didn't open an issue for the pull request due to the minor changes. Please let me know, if I should open one.

Description:

It seems that there are few duplicated operation IDs in controllers. So, I encountered the errors on a OpenAPI schema validator with swagger.json.

https://editor.swagger.io/

Semantic error at paths./api/v1/projects/{projectUuid}/git-integration/pull-requests/custom-metrics.post.operationId
Operations must have unique operationIds.
Jump to line 10103
Semantic error at paths./api/v1/saved/{chartUuid}/chart-and-results.post.operationId
Operations must have unique operationIds.
Jump to line 12528
Semantic error at paths./api/v1/saved/{chartUuid}/version/{versionUuid}.get.operationId
Operations must have unique operationIds.
Jump to line 12644

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@netlify Netlify
Copy link

netlify bot commented Aug 2, 2024

👷 Deploy request for peaceful-bassi-cbf284 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e924629

@yu-iskw yu-iskw marked this pull request as ready for review August 2, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yu-iskw