fix: show popover on paste #10970
Merged
fix: show popover on paste #10970
248
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlas
requested a deployment
to
fix/show-popover-on-paste - jaffle_db_pg_13 PR #10970
Render
Abandoned
owlas
deployed
to
fix/show-popover-on-paste - headless-browser PR #10970
Render
Active
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
owlas
temporarily deployed
to
fix/show-popover-on-paste - lightdash PR #10970
Render
Destroyed
owlas
deployed
to
fix/show-popover-on-paste - headless-browser PR #10970
Render
Active
rephus
approved these changes
Aug 2, 2024
Just waiting on: #10989 to be merged so we can run CI and make sure it isn't breaking anything 💪 |
almeidabbm
force-pushed
the
fix/show-popover-on-paste
branch
from
1442edd
to
3fe2b0d
Compare
owlas
temporarily deployed
to
fix/show-popover-on-paste - lightdash PR #10970
Render
Destroyed
owlas
temporarily deployed
to
fix/show-popover-on-paste - headless-browser PR #10970
Render
Destroyed
lightdash-bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
## [0.1202.5](0.1202.4...0.1202.5) (2024-08-05) ### Bug Fixes * show popover on paste ([#10970](#10970)) ([811aebc](811aebc))
|
🎉 This PR is included in version 0.1202.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When pasting a value into a filter our default behavior was to always add it as multiple values when the clipboard contents had commas.
This PR makes it so that when pasting a comma separated value we ask for user input on how the value should be treated
chart filters
Screen.Recording.2024-08-02.at.09.37.34.mov
dashboard filters
Reviewer actions