Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary value on required filter #10968

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

rephus
Copy link
Collaborator

@rephus rephus commented Aug 2, 2024

Closes: #10868

Description:

Screencast.from.02-08-24.09.42.25.webm

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@rephus rephus requested a review from joaoviana August 2, 2024 07:48
@owlas owlas requested a deployment to temporary-value-required-filter - jaffle_db_pg_13 PR #10968 August 2, 2024 07:48 — with Render Abandoned
@owlas owlas temporarily deployed to temporary-value-required-filter - headless-browser PR #10968 August 2, 2024 07:48 — with Render Destroyed
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for peaceful-bassi-cbf284 ready!

Name Link
🔨 Latest commit 1d0ec4b
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/66ac8f35fa1ce9500884ff2c
😎 Deploy Preview https://deploy-preview-10968--peaceful-bassi-cbf284.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rephus
Copy link
Collaborator Author

rephus commented Aug 2, 2024

@TuringLovesDeathMetal coud you take a look at the video ?

@owlas owlas temporarily deployed to temporary-value-required-filter - lightdash PR #10968 August 2, 2024 07:49 — with Render Destroyed
@rephus rephus requested a review from almeidabbm August 5, 2024 07:21
Copy link
Contributor

@joaoviana joaoviana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in Render 👍

@rephus rephus merged commit e78094b into main Aug 5, 2024
46 of 52 checks passed
@rephus rephus deleted the temporary-value-required-filter branch August 5, 2024 09:25
lightdash-bot pushed a commit that referenced this pull request Aug 5, 2024
## [0.1202.6](0.1202.5...0.1202.6) (2024-08-05)

### Bug Fixes

* temporary value on required filter ([#10968](#10968)) ([e78094b](e78094b))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1202.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants