Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli compile joined models on select and exclude #10964

Closed
wants to merge 6 commits into from

Conversation

almeidabbm
Copy link
Contributor

@almeidabbm almeidabbm commented Aug 1, 2024

Closes: #4748

Description:

  • Runs dbt parse to generate a manifest before compiling all the models and their joins (looks recursively and takes into account --select and --exclude opts)
Screen.Recording.2024-08-01.at.15.34.21.mov

test-cli

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@almeidabbm almeidabbm requested a review from a team August 1, 2024 14:38
@almeidabbm almeidabbm self-assigned this Aug 1, 2024
@almeidabbm almeidabbm requested review from magnew and removed request for a team August 1, 2024 14:38
@owlas owlas requested a deployment to fix/cli-join-compile - jaffle_db_pg_13 PR #10964 August 1, 2024 14:38 — with Render Abandoned
@owlas owlas temporarily deployed to fix/cli-join-compile - headless-browser PR #10964 August 1, 2024 14:38 — with Render Destroyed
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit 9bf1e79
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/66b0f0981a208e00080fa4f7

@owlas owlas deployed to fix/cli-join-compile - headless-browser PR #10964 August 1, 2024 14:39 — with Render Active
@owlas owlas deployed to fix/cli-join-compile - headless-browser PR #10964 August 1, 2024 14:53 — with Render Active
@owlas owlas deployed to fix/cli-join-compile - headless-browser PR #10964 August 1, 2024 14:56 — with Render Active
Comment on lines 158 to 160
if (dbtVersion.startsWith('1.3.') || dbtVersion.startsWith('1.4.')) {
args.push('--write-manifest');
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.getdbt.com/reference/commands/parse

From DBT Docs: "Starting in v1.5, dbt parse will write or return a manifest, enabling you to introspect dbt's understanding of all the resources in your project."

@owlas owlas deployed to fix/cli-join-compile - headless-browser PR #10964 August 2, 2024 08:03 — with Render Active
@owlas owlas deployed to fix/cli-join-compile - headless-browser PR #10964 August 2, 2024 16:18 — with Render Active
Copy link
Contributor

@magnew magnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. This makes sense. I tested the basics but not anything really complex.

@owlas owlas temporarily deployed to fix/cli-join-compile - headless-browser PR #10964 August 5, 2024 15:05 — with Render Destroyed
@almeidabbm almeidabbm closed this Aug 5, 2024
@owlas owlas requested a deployment to fix/cli-join-compile - jaffle_db_pg_13 PR #11019 August 5, 2024 15:49 — with Render Abandoned
@owlas owlas temporarily deployed to fix/cli-join-compile - headless-browser PR #11019 August 5, 2024 15:49 — with Render Destroyed
@almeidabbm
Copy link
Contributor Author

Closed in favor of #11019
Couldn't trigger CI here

@owlas owlas temporarily deployed to fix/cli-join-compile - lightdash PR #11019 August 5, 2024 15:50 — with Render Destroyed
@almeidabbm almeidabbm deleted the fix/cli-join-compile branch August 5, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if you compile a model that’s using a joined model, we should automatically also compile any joined models
3 participants