fix: If a chart is deleted, It should be redirected to the dashboard #10951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for peaceful-bassi-cbf284 pending review.Visit the deploys page to approve it
|
owlas
changed the title
rephus
requested changes
Aug 6, 2024
packages/frontend/src/components/Explorer/SavedChartsHeader/index.tsx
Outdated
Show resolved
Hide resolved
IrakliJani
approved these changes
Aug 8, 2024
rephus
approved these changes
Aug 8, 2024
lightdash-bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## [0.1206.1](0.1206.0...0.1206.1) (2024-08-08) ### Bug Fixes * If a chart is deleted, It should be redirected to the dashboard ([#10951](#10951)) ([1c5c7a1](1c5c7a1))
|
🎉 This PR is included in version 0.1206.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: (#10819)
Description:
If we are editing chats from any dashboard, the history will include parameters like fromDashboard={dashboardId}. If we are editing chats from space, it will be null. I check if the search parameter is not null;
If it isn’t, I redirect to the dashboard, Otherwise I redirect to the home page.
https://www.loom.com/share/2c58db6dba4647deaf8bb95685f40b1e?sid=a5f8d6a7-6f18-4caa-8c97-f16d4a82391d
Reviewer actions