-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating a filter value resets all of my series configuration #10994
Comments
On the main issue represented by the video from the Slack issue, it seems that the filter affected the series values. We could be smarter with the EDIT It's quite tricky to pinpoint what is causing this issue. I just tested another similar scenario and it seems right to me - the colours for each series remain intact after applying a filter See before after |
@TuringLovesDeathMetal @joaoviana This happens when the pivot (grouped by) values change. Demo: demo.mp4Context:
Example:
On the second query we have the series:
Since the series references are different, we don't keep any configuration.
I believe this is the root problem. Users expect the settings for that group ( aka y-axis metric ) to be saved but it's not. At the moment, when the user updates that config we are updating all the series that belong to that group. We could save the Type, Axis, Value labels, Show symbol, Smooth. The new series would still have different colours. |
One Q on the example @ZeRego , if you revert the filter back to |
@joaoviana Yes. We recently started to store series colours so we know the color of a series that reappears. They are stored in |
Description
If I update a filter value, my chart configuration gets reset.
See user Slack video here: https://lightdash.slack.com/archives/C047QNA8YPR/p1722602240392489
Steps to Reproduce the Bug or Issue
I can't seem to reproduce this locally...
I've tried:
it seems to not break for me...
version
No response
Cloud or self-hosting
None
The text was updated successfully, but these errors were encountered: