Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore transformLoading when loading SQL chart on dashboard #10960

Open
joaoviana opened this issue Aug 1, 2024 · 0 comments
Open

Ignore transformLoading when loading SQL chart on dashboard #10960

joaoviana opened this issue Aug 1, 2024 · 0 comments
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience 🖥 frontend This issue requires changes to the frontend

Comments

@joaoviana
Copy link
Contributor

joaoviana commented Aug 1, 2024

Description

When we go from view to edit mode, the SQL chart renders a loading overlay.
Perhaps there's an issue where the config is detached and it reinstantiates the config so when it's transforming, it displays the loading overlay.

We should:

  • Only care about the loading state when the query is running (and ignore the transform being loaded) since on a Dashboard you can't edit the chart on the fly.
  • Figure out what's making the config getting transformed when going from view->edit mode and vice-versa
  • Memoize sql chart component

Steps to Reproduce the Bug or Issue

  1. Add SQL Chart to dashboard
  2. Save
  3. Go to edit mode
  4. See loading overlay
  5. Go back to view mode
  6. See loading overlay again

version

No response

Cloud or self-hosting

None

@joaoviana joaoviana added 🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience 🖥 frontend This issue requires changes to the frontend labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience 🖥 frontend This issue requires changes to the frontend
Projects
Status: 📝 To-Do
Development

No branches or pull requests

1 participant