Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround for pasting filter values that contain commas #10950

Closed
jpetey75 opened this issue Jul 31, 2024 · 2 comments
Closed

Add workaround for pasting filter values that contain commas #10950

jpetey75 opened this issue Jul 31, 2024 · 2 comments
Labels
✨ feature-request Request for a new feature or functionality

Comments

@jpetey75
Copy link
Contributor

Description

Allow strings that have commas as part of the string to be pasted into filters without breaking them into multiple values.

What problem does this solve?

When pasting values into a string filter, if the pasted value has commas in the string, Lightdash breaks the string into multiple pieces. That change was made here: #4899

Sometimes users need to add filter values that contain commas as part of the string, so we should offer a workaround and not force the string to break apart.
@jpetey75 jpetey75 added the ✨ feature-request Request for a new feature or functionality label Jul 31, 2024
@jpetey75
Copy link
Contributor Author

Customer slack convo about this here: https://lightdash.slack.com/archives/C06J7R3HC5C/p1722452478930419

@joaoviana
Copy link
Contributor

I believe this was done here: #10970 and it's released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ feature-request Request for a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpetey75 @joaoviana