Make the environment variable TZ effective in Docker and default to using the UTC timezone. #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2024 21:22
KUMAKAIHA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the Dockerfile to include setting the TZ variable, with the default UTC timezone. I also edited telemetry_db.php to add a timestamp for timezone configuration. Additionally, PHP now defaults to using UTC as the timezone when no TZ variable is passed.
I compiled a test Docker on my Mac, and everything runs fine on my Mac. However, the version compiled on Mac is for arm64, but I believe it shouldn't have a big impact on the amd64 version. I only tried adding the timezone as Shanghai and got the correct timezone on the query page. I hope to get more tests to ensure the stability of the project.