docs: Add module wrapper to ASN.1 literal usage examples #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d7a
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Nice! IMO a missing module header should result in an error here. My idea was that for something like inline ASN.1, users should use the asn1 macro, which generates a default module header if the input doesn't contain one. I guess that should be reflected more clearly in the docs. Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module definition seems to be missing in the
add_asn_literalusage examples, resulting in a parsing error.Not sure if your intention is later to create internally and output a module definition if the user does not provide it, could be a cool feature :)