Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 385 and fix 393 #395

Merged
merged 13 commits into from
Nov 4, 2022
Merged

fix 385 and fix 393 #395

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift click to select a range
d1d3cb4
Add condition to fail tag creation when elem_count is a negative valu…
tinajohnson Jul 1, 2022
72e469f
Change CI build to use Visual Studio 17 2022. Apparently version 16 …
kyle-github Jul 1, 2022
9934575
Add checks to prevent out-of-bounds write on tag->encoded_name (#368)
tinajohnson Jul 1, 2022
461667f
Merge branch 'release' into prerelease
kyle-github Jul 2, 2022
5c52454
Update stable vs. unstable versions.
kyle-github Jul 2, 2022
606517a
Bump version for next release.
kyle-github Jul 2, 2022
3d79eca
Fix 378. Refactor condition var signal into common exit path of sta…
kyle-github Aug 23, 2022
b7287c2
Fix 381 (#382)
kyle-github Sep 24, 2022
7ffe02a
Add null terminator to tag->name string (#372)
tinajohnson Sep 24, 2022
2019721
Fix modbus test server (#389)
kyle-github Oct 15, 2022
9cac9d0
Update if guard to set up MSVC-style defines if MinGW64 is used. (#390)
kyle-github Oct 15, 2022
af44fe8
Fix 393 (#394)
kyle-github Nov 4, 2022
ecef1aa
Merge branch 'release' into prerelease
kyle-github Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 381 (#382) 
* Fix 378.   Refactor condition var signal into common exit path of state SESSION_OPEN_SOCKET_START.

* Fix 381. Incorrect comparison in loop guarding cond_wait from spurious wakeups.
  • Loading branch information
@kyle-github
kyle-github authored Sep 24, 2022
commit b7287c2bbfb77ace0040aa274120b64cf37638c9
4 changes: 2 additions & 2 deletions src/lib/lib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1644,7 1644,7 @@ LIB_EXPORT int plc_tag_read(int32_t id, int timeout)
pdebug(DEBUG_WARN, "Error %s while trying to read tag!", plc_tag_decode_error(rc));
plc_tag_abort(id);
}
} while(rc == PLCTAG_STATUS_PENDING && time_ms() > end_time);
} while(rc == PLCTAG_STATUS_PENDING && time_ms() < end_time);

/* the read is not in flight anymore. */
critical_block(tag->api_mutex) {
Expand Down Expand Up @@ -1849,7 1849,7 @@ LIB_EXPORT int plc_tag_write(int32_t id, int timeout)
pdebug(DEBUG_WARN, "Error %s while trying to write tag!", plc_tag_decode_error(rc));
plc_tag_abort(id);
}
} while(rc == PLCTAG_STATUS_PENDING && time_ms() > end_time);
} while(rc == PLCTAG_STATUS_PENDING && time_ms() < end_time);

/* the write is not in flight anymore. */
critical_block(tag->api_mutex) {
Expand Down