Add checks to prevent out-of-bounds write on tag->encoded_name #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, same CI problem as the other PR. I think this is a good start, but I think that there might be other areas where this could happen. |
|
Moving to prerelease for CI fix up addition. |
kyle-github
added a commit
that referenced
this pull request
Jul 1, 2022
…370) * Add condition to fail tag creation when elem_count is a negative value. (#366) Fixes #365 * Change CI build to use Visual Studio 17 2022. Apparently version 16 is gone on Github? * Add checks to prevent out-of-bounds write on tag->encoded_name (#368) Fixes #367 Co-authored-by: Tina Johnson <[email protected]>
kyle-github
added a commit
that referenced
this pull request
Sep 24, 2022
…rrect comparison (#383) * Add condition to fail tag creation when elem_count is a negative value. (#366) Fixes #365 * Change CI build to use Visual Studio 17 2022. Apparently version 16 is gone on Github? * Add checks to prevent out-of-bounds write on tag->encoded_name (#368) Fixes #367 * Update stable vs. unstable versions. * Bump version for next release. * Fix 378. Refactor condition var signal into common exit path of state SESSION_OPEN_SOCKET_START. * Fix 381. Incorrect comparison in loop guarding cond_wait from spurious wakeups. * Add null terminator to tag->name string (#372) Fixes #371 Co-authored-by: Tina Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367