Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an scm rockspec #305

Merged
merged 1 commit into from
Nov 22, 2022
Merged

add an scm rockspec #305

merged 1 commit into from
Nov 22, 2022

Conversation

leafo
Copy link
Contributor

@leafo leafo commented Nov 22, 2022

This adds a rockspec that can build from the master branch of the source repository. In this convention we check this rockspec in because it can be used universally. Generally versioned rockspecs you don't check in.

This will enable someone to build and install the latest version via LuaRocks with a command like:

luarocks install https://raw.githubusercontent.com/lgi-devs/lgi/master/lgi-scm-1.rockspec

After this change is accepted, we can also upload the scm rockspec to luarocks.org so we can use the "dev" manifest to also install the development version of this module

@Frityet
Copy link

Frityet commented Nov 18, 2023

It doesn't seem that the scm rockspec is the same that is uploaded to the luarocks.org/dev server, is this intentional?

@psychon

@psychon
Copy link
Collaborator

psychon commented Nov 18, 2023

Dunno what you mean exactly, but according to https://luarocks.org/modules/pavouk/lgi, pavouk last uploaded something 6 years ago, but this PR is only one year old, so obviously newer than that.

@Frityet
Copy link

Frityet commented Nov 18, 2023

Oh, I just realized there is no dev upload for lgi in general, could that be considered? It would allow the latest source release of lgi to be installed with luarocks install --server=https://luarocks.org/dev lgi

@psychon
Copy link
Collaborator

psychon commented Nov 18, 2023

Well, feel free to do that. You are in a better position to do that than I am since you apparently use luarocks and understand how it works. According to https://github.com/pavouk?tab=overview&from=2015-11-01&to=2023-11-18, pavouk was last active eight years ago, so I wouldn't expect that he uploads something there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants