Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow !important case-insensitive token #3732

Closed
wants to merge 1 commit into from
Closed

Allow !important case-insensitive token #3732

wants to merge 1 commit into from

Conversation

lefevre00
Copy link

What:
Fixes #3731

Why:
According to https://www.w3.org/TR/css-syntax-3/#consume-declaration the token important is case-insensitive.

How:
Make the regex case-insensitive

Checklist:

  • Documentation N/A
  • Added/updated unit tests
  • Code complete

@iChenLei
Copy link
Member

Thank you for your contribution, LGTM. But also need @matthew-dean review.

https://www.w3.org/TR/css-syntax-3/#consume-declaration

  1. If the last two non-s in the declaration’s value are a with the value "!" followed by an with a value that is an ASCII case-insensitive match for "important", remove them from the declaration’s value and set the declaration’s important flag to true.

@iChenLei
Copy link
Member

closed by #3731 (comment)

@iChenLei iChenLei closed this Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Important token should be case insensitive
2 participants
@lefevre00 @iChenLei