Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser field #2525

Merged
merged 1 commit into from
Apr 1, 2015
Merged

Add browser field #2525

merged 1 commit into from
Apr 1, 2015

Conversation

wclr
Copy link
Contributor

@wclr wclr commented Mar 28, 2015

to support browserfy and other loaders that use browser field for resolving browser version
https://github.com/substack/node-browserify#packagejson

to support browserfy and other loaders that use `browser` field for resolving browser version
https://github.com/substack/node-browserify#packagejson
@lukeapage
Copy link
Member

thanks.

lukeapage added a commit that referenced this pull request Apr 1, 2015
@lukeapage lukeapage merged commit 1e67f03 into less:master Apr 1, 2015
@jonnor
Copy link

jonnor commented Apr 18, 2015

I suspect that this actually breaks browserify support...
When depending on less in another project, and there using browserify to bundle my project, I get:

Running "browserify:src" (browserify) task
>> Error: Cannot find module './utils' from '/home/jon/work/thegrid/taylor/node_modules/less/dist'

Not having such problems with 2.4.0

@wclr
Copy link
Contributor Author

wclr commented Apr 18, 2015

@jonnor but without it browserfy will require node-version. There is not need parse dist ready browser version There noParse option to skip parsing of require statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants