Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made show fallback optional #1817

Merged
merged 3 commits into from
Oct 2, 2023
Merged

made show fallback optional #1817

merged 3 commits into from
Oct 2, 2023

Conversation

maccesch
Copy link
Contributor

Fixes #1760

@gbj
Copy link
Collaborator

gbj commented Sep 30, 2023

Dare I mention that the same Fallback type should be reusable for Suspense and Transition too, unless I'm missing something? Would you like to try to include that in this PR? If not, we can handle it separately.

This seems obviously good to me, I don't know why I didn't do it a long time ago other than stubbornness and lack of creativity! 😄

@maccesch
Copy link
Contributor Author

maccesch commented Sep 30, 2023

Working on a project for a long time seems to make some amount of tunnel vision unavoidable. At least for me it's like that.

I renamed the struct to ViewFn because that seems to describe it better to me. I didn't add this to ErrorBoundary because I don't think we should encourage irgnoring errors 😄 .

@gbj
Copy link
Collaborator

gbj commented Oct 2, 2023

Working on a project for a long time seems to make some amount of tunnel vision unavoidable.

This is 100% my experience too!

Thanks so much for taking the time — this will be such a nice quality-of-life improvement for everyone.

@gbj gbj merged commit 6d44540 into leptos-rs:main Oct 2, 2023
56 checks passed
@gbj gbj mentioned this pull request Oct 2, 2023
10 tasks
maccesch added a commit to maccesch/leptos that referenced this pull request Oct 7, 2023
@maccesch maccesch deleted the show-opt-fallback branch September 14, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For the Show component, make the fallback property or default to an empty view
2 participants