Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement window rule for hiding_strategy #1284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Syudagye
Copy link
Contributor

Description

In addition of #1274, this PR adds a new window rule parameter in case some window do not behave correctly under MoveMinimize or MoveOnly hiding behaviours, or if you want to be able to share specific windows but still have Unmap for other windows.

Type of change

  • Development change (no change visible to user)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation only update (no change to the factual codebase)
  • This change requires a documentation update

Updated user documentation:

  • hiding_strategy When specified, will force the window to hide in a certain way. See window_hiding_strategy for values.

Checklist:

  • Ran make test locally with no errors or warnings reported
    Note: To fully reproduce CI checks, you will need to run make test-full-nix. Usually, this is not necessary.
  • Manual page has been updated accordingly
  • Wiki pages have been updated accordingly (to perform after merge)

@Syudagye
Copy link
Contributor Author

an example situation where this could be useful: #1283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant