Gather qt5 in main page for a full build compile all in once (leelaz /-autogtp) clearer main README more detailed AUTOGTP readme #2071
Conversation
|
after running this :
added cmake dependency to fix this error on a brand new ubuntu : |
after running this : sudo apt install libboost-dev libboost-program-options-dev libboost-filesystem-dev opencl-headers ocl-icd-libopencl1 ocl-icd-opencl-dev zlib1g-dev added cmake dependency to fix this error on a brand new ubuntu : cmake .. Command 'cmake' not found, but can be installed with: apt install cmake Please ask your administrator.
|
adding qt5 dependency to fix compile incomplete (error after compile : autogtp is not a directory without qt5) for linux :
for macos :
note : for macos i dont know if and removing it from the autogtp readme (uneeded to separate instructions) |
qt5 is needed for autogtp to be compiled to make it less confusing, i am integrating qt5 directly in main page examples of compiling This autogtp README page now links to the main readme
since the compiling is all in one step now with cmake, i think it's better to include qt5 dependency here instead of in the autogtp readme fixes the autogtp is not a directory error when following these new instructions without reading the autogtp readme page (i.e. without having qt5 installed) note : i dont know if qt5 and curl have the same package names on macos, edit if it's wrong
wonderingabout
changed the title
|
finished, it looks so much clearer for a newcomer edit 2 : again i want to stress that for mac version i dont know if @gcp can you review again please ? |
again i dont know if brew install qt5 will install qmake for autogtp in macos
wonderingabout
changed the title
wonderingabout
changed the title
|
trying an attemptive revert, will be done in a few hours |
reverted separate qt5 methodology with a detailed explanation i think it makes more sense like that
|
after thinking it again, i can see many cases where one person may want to compile only autogtp binary without leelaz did an attemptive revert, |
|
will update the PR's mac building instructions depending on the evolution here : |
|
added help on autogtp for easier use, see #1400 |
|
So, i would like to conclude this PR if possible @gcp I dont have anything else to add, and i corrected the PR based on your first review, but i would like to conclude on this PR please @gcp are there errors to fix ? i remember that the base draft of this PR was quite good so we tried to improve it can we review again and conclude soon ? |
as mentionned by @rakenodiax here : #2177 (comment)
Update links to leela-zero instead of gcp.
Appveyor link still needs to be 'gcp'.
|
@Hersmunch @ihavnoid @marcocalignano @sethtroisi @Ttl @gcp i fixed this PR for a long time now, would like if we can review it again big thanks 👍 |
|
i want to point again that all mac instructions may not be 100% accurate since i dont use mac myself (i'm on linux), and wrote these based on users's issues and feedback but the main point of this PR is making the documentation clearer and more friendly as a whole |
|
Oh sorry I made some direct changes to the README file without even realizing this PR was here. However it might not conflict yours at all, I mostly just changed the AppVeyor links. |
|
this PR is only documentation changes, so i hope nothing major will conflict with it its fine for the change, i just commited the one line change (if anything, i should have changed new owner too here) again, i want to remind that mac instructions may not be 100% accurate @roy7 , as i wrote them based on mac users feedback but all in all, this PR should bring good things to leela-zero documentation |
gcp
force-pushed
the
next
branch
3 times, most recently
from
d5e3539 to
6aaa5bb
Compare
|
@Hersmunch @ihavnoid @marcocalignano @sethtroisi @Ttl @gcp please, please, please i am ready to add or remove anything that may not be needed or accurate, but please can we come with a conclusion on this reasonably soon thanks 👍 i just fixed conflicts with newest next branch changes again today |
it seems i was the one to have introduced that mistake somehow earlier
|
i'll rewrite this from scratch in one commit with proper commit message too poor quality to merge it in 0.17 #2275 |
My next branch is now in sync with gcp/next
this branch is a copy of gcp/next with a few new commits
general outlook
you can compare it to :