-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.1.0-rc PR #537
base: master
Are you sure you want to change the base?
v0.1.0-rc PR #537
Conversation
# Conflicts: # internal/master/server/namespace/handlers.go # internal/master/state/state.go
internal/server/config/config.go
Outdated
@@ -32,10 32,9 @@ type Config struct { | |||
Token string `yaml:"token,omitempty"` | |||
} `yaml:"security,omitempty"` | |||
|
|||
WorkDir string `yaml:"workdir"` | |||
RootDir string `yaml:"root-dirr"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is second "r" is redundant? root-dirr
.
internal/cli/command/daemon/agent.go
Outdated
if apiTlsCa != "" { | ||
cfg.API.TLS.FileCert = apiTlsCert | ||
apiTLSCert := os.Getenv("LB_API_TLS_CERT_FILE") | ||
if apiTLSCa != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you use incorrect variable. I think apiTLSCert
should be instead of apiTLSCa
.
internal/cli/command/daemon/agent.go
Outdated
if apiTlsCa != "" { | ||
cfg.API.TLS.FileKey = apiTlsKey | ||
apiTLSKey := os.Getenv("LB_API_TLS_PRIVATE_KEY_FILE") | ||
if apiTLSCa != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you use incorrect variable. I think apiTLSKey
should be instead of apiTLSCa
.
internal/cli/command/daemon/agent.go
Outdated
if manifefstdir != "" { | ||
cfg.ManifestDir = manifefstdir | ||
storageDriver := os.Getenv("LB_STORAGE_DRIVER") | ||
if rootDir != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you use incorrect variable. I think storageDriver
should be instead of rootDir
.
@@ -0,0 1,50 @@ | |||
# Build manifest | |||
FROM golang:1.11-alpine3.8 as build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In go.mod
you use 1.14.
@@ -0,0 1,35 @@ | |||
# Build manifest | |||
FROM golang:1.11-alpine3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In go.mod
you use 1.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, in another Dockerfile (build/docker/lastbackend/Dockerfile.stg
).
switch u.Scheme { | ||
case "tcp": | ||
return "tcp", u.Host, nil | ||
case "unix": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a variable for this string. You use it in the line 45 for example.
Kudos, SonarCloud Quality Gate passed! |
Fixes
Description
v.0.1.0-rc release candidate PR.
Contains a lot of changes and improvements.
After switching to go-modules, docker images didn't passed build process.
Version
v0.1.0-rc