Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant return key like for all when methods for databas… #592

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Remove redundant return key like for all when methods for databas… #592

merged 1 commit into from
Feb 18, 2022

Conversation

siarheipashkevich
Copy link
Contributor

@siarheipashkevich siarheipashkevich commented Feb 18, 2022 •
edited
Loading

No description provided.

@siarheipashkevich
Copy link
Contributor Author

siarheipashkevich commented Feb 18, 2022 •
edited
Loading

@driesvints I wanna ask you, in the docs can we remove also return key https://laravel.com/docs/9.x/queries#conditional-clauses ?

@driesvints
Copy link
Member

@siarheipashkevich yeah think so 👍

@siarheipashkevich siarheipashkevich mentioned this pull request Feb 18, 2022
Merged
@siarheipashkevich siarheipashkevich changed the title Remove redundant 'return' key like for all 'when' methods for databas… Remove redundant return key like for all when methods for databas… Feb 18, 2022
@taylorotwell taylorotwell merged commit 72be0a7 into laravel:9.x Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siarheipashkevich @driesvints @taylorotwell