[1.x] Only support MariaDB 11 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
Seems the problem was my local setup, now no database creation errors happen anymore on my side. |
driesvints
approved these changes
Jul 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #698 and #703 to only one supported MariaDB Version.
Laravel Sail only supports one MySQL version (MySQL 8). The problems which arise with multiple versions of MariaDB, introduce unneeded complexity.
Therefor this PR reverts back to only on supported MariaDB Version, which is now MariaDB 11 instead of MariaDB 10, which it was before the other PRs.
See Issues: #702 and #701
After this is merged and released, I will also revert the changes in the Laravel Sail Server Script: laravel/sail-server#24
How to test the changes:
laravel new sail-test --no-interaction cd sail-test composer config repositories.sail vcs https://github.com/Jubeki/laravel-sail.git composer require laravel/sail:dev-mariadb11 --dev php artisan sail:install --with=mariadb vendor/bin/sail up -d --wait vendor/bin/sail artisan migrate open http://localhostPlease don't forget to stop the docker container after testing: