[1.x] Install "mariadb-client" package for MariaDB users #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
I like this approach @staudenmeir, nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to laravel/framework#51355:
We need to switch the MariaDB's driver dump binary from
mysqldumptomariadb-dumpat some point as MariaDB will remove its support formysqldump. The issue is that Sail doesn't supportmariadb-dumpyet.I looked into using the dump binaries from the actual
mysql/mariadbcontainers, but that's a nightmare.Instead, my suggestion is to install the
mariadb-clientpackage instead ofmysql-clientin the app container when the MariaDB service is requested. This package provides the necessarymariadb-dumpbinary.As discussed with @driesvints in the other PR, we should only switch to
mariadb-dumpin Laravel 12 and this PR prepares Sail for that switch. I only adjusted theDockerfilefor PHP 8.3 as I assumed that Laravel 12 will drop support for PHP 8.2.I don't see any breaking changes for Sail users:
MYSQL_CLIENT="mysql-client", nothing changes for existing users after updating to the latest version.mariadb-clientpackage creates a symlinkmysqldump -> mariadb-dump.@driesvints What do you think about this approach?