Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell - display available commands / help section #359

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Shell - display available commands / help section #359

merged 7 commits into from
Mar 17, 2022

Conversation

WalterWoshid
Copy link
Contributor

Changes:

  • vendor/bin/sail now executes the help section, instead of the docker ps command
  • New command aliases for the help section: sail help, sail -help, sail --help and sail -h
  • New command alias for docker-compose: sail docker-compose
    • (Unknown commands still proxy to docker-compose)
  • New command alias for root-shell: root-bash
  • ShellCheck corrections

Preview

image
image

@taylorotwell
Copy link
Member

What it looks like on my Mac:

CleanShot 2022-03-16 at 11 35 41@2x

@taylorotwell taylorotwell marked this pull request as draft March 16, 2022 16:36
@taylorotwell
Copy link
Member

You can mark as ready for review once this is ready... otherwise I won't see it.

@WalterWoshid WalterWoshid marked this pull request as ready for review March 17, 2022 07:57
@WalterWoshid
Copy link
Contributor Author

@taylorotwell Tested on Mac and Ubuntu, now it should only work if the terminal supports colors

I have also moved the help section above the docker checks, which makes the help section run immediately

@taylorotwell taylorotwell merged commit f69380f into laravel:1.x Mar 17, 2022
@WalterWoshid WalterWoshid deleted the 1.x-shell branch March 18, 2022 06:01
@driesvints driesvints mentioned this pull request Jun 8, 2022
Closed
@driesvints
Copy link
Member

@WalterWoshid fixed something that got accidentally changed here: #427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WalterWoshid @taylorotwell @driesvints