Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capability to set custom headers to Azure OpenAI model's builders #1752

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

afrancescon
Copy link
Contributor

@afrancescon afrancescon commented Sep 10, 2024

Issue

Closes #1751

Change

Added customHeader(Map<String, String> customHeaders) method to Azure OpenAI model builders.

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green

Copy link

/cc @agoncal (azure), @jdubois (azure)

Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrancescon thank you!

Could you please add it to the Spring Boot starter as well?

@langchain4j langchain4j merged commit c804933 into langchain4j:main Sep 11, 2024
1 check passed
jdubois pushed a commit to jdubois/langchain4j that referenced this pull request Sep 20, 2024
…rs (langchain4j#1752)

## Issue
Closes langchain4j#1751 

## Change
Added `customHeader(Map<String, String> customHeaders)` method to Azure
OpenAI model builders.

## General checklist
<!-- Please double-check the following points and mark them like this:
[X] -->
- [x] There are no breaking changes
- [ ] I have added unit and integration tests for my change
- [x] I have manually run all the unit and integration tests in the
module I have added/changed, and they are all green
- [x] I have manually run all the unit and integration tests in the
[core](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-core)
and
[main](https://github.com/langchain4j/langchain4j/tree/main/langchain4j)
modules, and they are all green
<!-- Before adding documentation and example(s) (below), please wait
until the PR is reviewed and approved. -->
- [ ] I have added/updated the
[documentation](https://github.com/langchain4j/langchain4j/tree/main/docs/docs)
- [ ] I have added an example in the [examples
repo](https://github.com/langchain4j/langchain4j-examples) (only for
"big" features)
- [ ] I have added/updated [Spring Boot
starter(s)](https://github.com/langchain4j/langchain4j-spring) (if
applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add custom headers on Azure OpenAI model builders
2 participants