Added apiCallTimeout param for Bedrock and it fixes langchain4j/langc… #1726
12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langchain4j
reviewed
Sep 9, 2024
| @@ -47,6 49,8 @@ public abstract class AbstractSharedBedrockChatModel { | |||
| @Builder.Default | |||
| protected final int topK = 250; | |||
| @Builder.Default | |||
| protected final Duration timeout = Duration.ofMinutes(5L); | |||
There was a problem hiding this comment.
5 minutes seems too high... What about 1 minute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1704
Change
Added timeout support in BedrockCharModel. The default timeout is set to 1 minute.
General checklist
I only ran core module, and I didn't run main as I don't have openAiApiKey
Checklist for adding new model integration
Checklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreITthat extends from eitherEmbeddingStoreITorEmbeddingStoreWithFilteringITChecklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStoreworks correctly with the data persisted using the latest released version of LangChain4j