Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme #10

Merged
merged 4 commits into from
Dec 21, 2021
Merged

Update Readme #10

merged 4 commits into from
Dec 21, 2021

Conversation

sum1112
Copy link
Contributor

@sum1112 sum1112 commented Dec 18, 2021

corrected the typo in api options, apiKey is string and tmdbId is number

sum1112 and others added 4 commits December 19, 2021 00:36
corrected the typo in api options, apiKey is string and tmdbId is number
In previous code after finding no movie trailer id, it would search again but omit the parameter language, and also create TypeError as you cannot read properties of null object.
Copy link
Owner

@lacymorrow lacymorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lacymorrow lacymorrow merged commit b1dd0f0 into lacymorrow:master Dec 21, 2021
@lacymorrow
Copy link
Owner

That was a good catch @sum1112 , I appreciate the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants